Skip to content

Fix typo in CONTRIBUTING and README #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix typo in CONTRIBUTING and README #3736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99f233d
Fix typo
ngocnhan-tran1996 Feb 10, 2025
483e8f1
Revert CONTRIBUTING.adoc
ngocnhan-tran1996 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ From the command line you can check this using:
log --graph --pretty=oneline
----

As this may cause lots of typing, we recommend creating a global alias, e.g. `git logg` for this:
As this may cause lots of typing, we recommend creating a global alias, e.g. `git log` for this:

----
git config --global alias.logg 'log --graph --pretty=oneline'
git config --global alias.log 'log --graph --pretty=oneline'
Copy link
Member

@artembilan artembilan Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a correct change.
There is already git log, and this section really talks about a custom one to include those options.
Therefore we cannot call a new alias as log and have to chose other name.

----

This command, will provide the following output, which in this case shows a nice linear history:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Spring for Apache Kafka

# Code of Conduct

Please see our [Code of conduct](https://github.com/spring-projects/.github/blob/master/CODE_OF_CONDUCT.md).
Please see our [Code of conduct](https://github.com/spring-projects/.github/blob/main/CODE_OF_CONDUCT.md).

# Reporting Security Vulnerabilities

Expand Down