-
Notifications
You must be signed in to change notification settings - Fork 1.7k
GH-3869: Should fail bean registration when no method β¦ #3870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
696f48f
6937686
cc8a42f
c3f44f1
827e308
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -407,18 +407,32 @@ public Object postProcessAfterInitialization(final Object bean, final String bea | |
| this.logger.debug(() -> annotatedMethods.size() + " @KafkaListener methods processed on bean '" | ||
| + beanName + "': " + annotatedMethods); | ||
| } | ||
| Set<Method> methodsWithHandler = MethodIntrospector.selectMethods(targetClass, | ||
| (ReflectionUtils.MethodFilter) method -> | ||
| AnnotationUtils.findAnnotation(method, KafkaHandler.class) != null); | ||
| boolean hasMethodLevelKafkaHandlerAnnotation = !methodsWithHandler.isEmpty(); | ||
| if (hasClassLevelListeners) { | ||
| Set<Method> methodsWithHandler = MethodIntrospector.selectMethods(targetClass, | ||
| (ReflectionUtils.MethodFilter) method -> | ||
| AnnotationUtils.findAnnotation(method, KafkaHandler.class) != null); | ||
| List<Method> multiMethods = new ArrayList<>(methodsWithHandler); | ||
| processMultiMethodListeners(classLevelListeners, multiMethods, targetClass, bean, beanName); | ||
| } | ||
| throwErrorIfNoListenerMethods(bean, hasMethodLevelListeners, | ||
| hasClassLevelListeners, hasMethodLevelKafkaHandlerAnnotation); | ||
| } | ||
| } | ||
| return bean; | ||
| } | ||
|
|
||
| private void throwErrorIfNoListenerMethods(Object bean, boolean hasMethodLevelListeners, | ||
| boolean hasClassLevelListeners, boolean hasMethodLevelKafkaHandlerAnnotation) { | ||
| if (hasMethodLevelListeners) { | ||
| return; | ||
|
||
| } | ||
|
|
||
| if (hasClassLevelListeners && !hasMethodLevelKafkaHandlerAnnotation) { | ||
| throw new IllegalStateException("No kafka listener methods found on bean type: " + bean.getClass()); | ||
|
||
| } | ||
| } | ||
|
|
||
| /* | ||
| * AnnotationUtils.getRepeatableAnnotations does not look at interfaces | ||
| */ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Copyright 2017-2025 the original author or authors. | ||
|
||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.kafka.annotation; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import org.springframework.beans.factory.BeanCreationException; | ||
| import org.springframework.context.annotation.AnnotationConfigApplicationContext; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| /** | ||
| * @author Sanghyeok An | ||
| * | ||
| * @since 4.0.0 | ||
| */ | ||
|
|
||
| class KafkaListenerAnnotationBeanPostProcessorTest { | ||
|
||
|
|
||
| @Test | ||
| void ctx_should_be_fail_to_register_bean_when_no_listener_methods_exist() { | ||
| // GIVEN | ||
| AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext(); | ||
| ctx.register(TestConfig.class); | ||
|
|
||
| // GIVEN - expected | ||
| Class<?> expectedErrorType = BeanCreationException.class; | ||
| String expectedErrorMsg = | ||
| "Error creating bean with name 'org.springframework.kafka.annotation." | ||
| + "KafkaListenerAnnotationBeanPostProcessorTest$TestConfig$BuggyListener': " | ||
| + "No kafka listener methods found on bean type: class org.springframework.kafka" | ||
| + ".annotation.KafkaListenerAnnotationBeanPostProcessorTest$TestConfig$BuggyListener"; | ||
|
|
||
| // WHEN + THEN | ||
| assertThatThrownBy(ctx::refresh) | ||
| .isInstanceOf(expectedErrorType) | ||
| .hasMessage(expectedErrorMsg); | ||
|
||
| } | ||
|
|
||
| @Configuration | ||
| static class TestConfig { | ||
|
|
||
| @Bean | ||
| public KafkaListenerAnnotationBeanPostProcessor<Object, Object> kafkaListenerAnnotationBeanPostProcessor() { | ||
|
||
| return new KafkaListenerAnnotationBeanPostProcessor<>(); | ||
| } | ||
|
|
||
| @Component | ||
| @KafkaListener | ||
| static class BuggyListener { | ||
|
||
|
|
||
| public void listen(String message) { | ||
| return; | ||
|
||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no need to do this extraction outside of the
if (hasClassLevelListeners) {branch.