Return ConsumerStoppedEvent with Abnormal reason when MLC stopped abn… #3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlamuriLokesh
force-pushed
the
feature/GH-3948
branch
from
926b75f to
057c8c5
Compare
artembilan
requested changes
Jun 6, 2025
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Signed-off-by: AlamuriLokesh
Please, consider to fix your Git client to provide your official name.
According to DCO, the legal obligations for contributed code has to be from official name, not nicknames.
Otherwise we cannot review and accept your change.
AlamuriLokesh
force-pushed
the
feature/GH-3948
branch
2 times, most recently
from
515211d to
e2626ed
Compare
Contributor
Author
Could you please review now. I have updated my name as |
artembilan
requested changes
Jun 6, 2025
spring-kafka/src/main/java/org/springframework/kafka/event/ConsumerStoppedEvent.java
Show resolved
Hide resolved
sobychacko
requested changes
Jun 6, 2025
Contributor
sobychacko
left a comment
sobychacko
left a comment
There was a problem hiding this comment.
Some minor comments. We need to add reference docs for this since this is a new addition.
spring-kafka/src/main/java/org/springframework/kafka/event/ConsumerStoppedEvent.java
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/event/ConsumerStoppedEvent.java
Show resolved
Hide resolved
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
Show resolved
Hide resolved
...rc/test/java/org/springframework/kafka/listener/ConcurrentMessageListenerContainerTests.java
Show resolved
Hide resolved
AlamuriLokesh
force-pushed
the
feature/GH-3948
branch
from
b95e9f3 to
cff0e99
Compare
…ormally Signed-off-by: Alamuri Lokesh <[email protected]>
AlamuriLokesh
force-pushed
the
feature/GH-3948
branch
from
cff0e99 to
e14e6c2
Compare
sobychacko
approved these changes
Jul 21, 2025
Contributor
|
Merged via c491502. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ormally