Improve code quality, documentation, and nullability annotations #4139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements several code quality improvements across the codebase: Bug Fixes: - Fix incorrect header constant in KafkaHeaders.java: ORIGINAL_CONSUMER_GROUP was using "dlt-original-consumer-group" instead of "original-consumer-group" to align with other ORIGINAL_* constants Nullability Annotations: - Add @nonnull annotations to methods that never return null: - AbstractMessageListenerContainer.getBeanName() - SendResult.getProducerRecord() and getRecordMetadata() - KafkaResourceHolder.getProducer() - EndpointHandlerMethod.getMethod() and getMethodName() - EndpointHandlerMultiMethod.getMethods() - ContainerGroup.getName() and getListenerIds() Error Handling: - Resolve TODO comments in DefaultKafkaProducerFactory by adding proper error handling to metric registration methods (registerMetricForSubscription and unregisterMetricFromSubscription) with consistent logging and producerFailed tracking, matching the pattern used in other transaction methods Documentation: - Enhance retrytopic package-info.java with comprehensive overview of retry topic infrastructure, core concepts, key components, and usage patterns - Add missing Javadoc to public methods: - FailedRecordProcessor.deliveryAttempt() and clearThreadState() - ConsumerRecordMetadata: all public methods (hasOffset, offset, hasTimestamp, timestamp, serializedKeySize, serializedValueSize, topic, partition, timestampType) These improvements enhance type safety, API clarity, error handling consistency, and developer experience when working with the Spring Kafka framework. Signed-off-by: sekka <[email protected]>
sekkaahmed
force-pushed
the
claude/improve-implementation-011CUoFDg8oNEReSFbruouYB
branch
from
51ff5dd to
351d176
Compare
Signed-off-by: AHMED SEKKA <[email protected]>
artembilan
requested changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements several code quality improvements across the codebase:
Bug Fixes:
Nullability Annotations:
Error Handling:
Documentation:
These improvements enhance type safety, API clarity, error handling consistency, and developer experience when working with the Spring Kafka framework.