Skip to content

Conversation

@vpavic
Copy link
Contributor

@vpavic vpavic commented Aug 29, 2024

This commit fixes invalid documentation references to spring.pulsar.consumer.subscription.type configuration property.

This commit fixes invalid documentation references to
`spring.pulsar.consumer.subscription.type` configuration property.
Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @vpavic

@onobc onobc merged commit 01a95a7 into spring-projects:main Aug 29, 2024
@vpavic vpavic deleted the fix-docs branch August 29, 2024 19:53
@vpavic
Copy link
Contributor Author

vpavic commented Aug 30, 2024

Thanks for merging - though it's funny how commit subject line ended up being something completely different/unrelated when merged on main. 🙂

I suggest you consider amending the commit and force pushing before further commits land on main.

@onobc
Copy link
Collaborator

onobc commented Aug 30, 2024

Thanks for merging - though it's funny how commit subject line ended up being something completely different/unrelated when merged on main. 🙂

Yeh, I did the rebase/merge in Github (which I rarely do) and I did not notice the wonky commit message. Seems like I am trying to self-promote lol - but trust me! I am not :)

I suggest you consider amending the commit and force pushing before further commits land on main.

Believe me, it crossed my mind and I was very tempted to do so. We have a hard policy never to force push on main. Personally, I am not against it in rare cases (like this). It would not hurt anything and it will avoid a ridiculous commit message. But I left it alone.

Lesson here is.... slow down and re-read your commits before pushing the button Chris. :)

@onobc onobc added this to the 1.2.0-M2 milestone Sep 13, 2024
@onobc onobc added the type: documentation A documentation update label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants