Skip to content

Conversation

ximinghui
Copy link
Contributor

The AuthenticationEventPublisher interface does not provide the setAdditionalExceptionMappings(Map<Class<? extends AuthenticationException) method, and it is located in the DefaultAuthenticationEventPublisher implementation class.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 3, 2024
@ximinghui
Copy link
Contributor Author

Since Spring Security 6.3.3 uses Java 17, the variable type declaration can also be changed to the var keyword available since Java 10+. However, I don’t see the var keyword used in the documentation, so I continue to use traditional type declarations to maintain consistency in the code style.

@jzheaux jzheaux self-assigned this Sep 3, 2024
@jzheaux jzheaux added the type: bug A general bug label Sep 3, 2024
@jzheaux jzheaux merged commit d23f283 into spring-projects:main Sep 3, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Sep 3, 2024

Thanks, @ximinghui! You are correct that Spring Security does not use var. That is because we try and align ourselves with Spring Framework's style guide.

@jzheaux jzheaux added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 3, 2024
@ximinghui ximinghui deleted the fix-typo-eventpublisher-type branch September 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants