Skip to content

Polish OneTimeTokenLogin #15750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2024
Merged

Polish OneTimeTokenLogin #15750

merged 4 commits into from
Sep 6, 2024

Conversation

Kehrlann
Copy link
Contributor

@Kehrlann Kehrlann commented Sep 6, 2024 •
edited
Loading

reviewer: @marcusdacoregio

Add the following (one commit per line):

  • The OneTimeToken default submit UI uses contextPath in the form POST action
  • Remove unused <script> and <noscript> tags in OTT submit page
  • Remove unused logger in OTT Configurer
  • Add OTT Configurer tests that renders the OTT request form on the default login UI

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2024
@Kehrlann Kehrlann mentioned this pull request Sep 6, 2024
Merged
@marcusdacoregio marcusdacoregio self-assigned this Sep 6, 2024
@marcusdacoregio marcusdacoregio added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 6, 2024
@marcusdacoregio marcusdacoregio added this to the 6.4.0-M4 milestone Sep 6, 2024
@marcusdacoregio marcusdacoregio merged commit 6428bf2 into spring-projects:main Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@marcusdacoregio marcusdacoregio

Labels

in: config An issue in spring-security-config type: enhancement A general enhancement

Projects

None yet

Milestone

6.4.0-M4

Development

Successfully merging this pull request may close these issues.

3 participants

@Kehrlann @marcusdacoregio @spring-projects-issues