Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.springframework.context.event.GenericApplicationListenerAdapter;
import org.springframework.context.event.SmartApplicationListener;
import org.springframework.core.ResolvableType;
import org.springframework.core.convert.converter.Converter;
import org.springframework.security.authentication.AuthenticationProvider;
import org.springframework.security.config.Customizer;
import org.springframework.security.config.annotation.web.HttpSecurityBuilder;
Expand All @@ -50,6 +51,7 @@
import org.springframework.security.core.session.SessionDestroyedEvent;
import org.springframework.security.core.session.SessionIdChangedEvent;
import org.springframework.security.oauth2.client.OAuth2AuthorizedClientService;
import org.springframework.security.oauth2.client.authentication.OAuth2AuthenticationToken;
import org.springframework.security.oauth2.client.authentication.OAuth2LoginAuthenticationProvider;
import org.springframework.security.oauth2.client.authentication.OAuth2LoginAuthenticationToken;
import org.springframework.security.oauth2.client.endpoint.DefaultAuthorizationCodeTokenResponseClient;
Expand Down Expand Up @@ -430,6 +432,10 @@ public void configure(B http) throws Exception {
authenticationFilter
.setAuthorizationRequestRepository(this.authorizationEndpointConfig.authorizationRequestRepository);
}
if (this.authorizationEndpointConfig.authenticationResultConverter != null) {
authenticationFilter
.setAuthenticationResultConverter(this.authorizationEndpointConfig.authenticationResultConverter);
}
configureOidcSessionRegistry(http);
super.configure(http);
}
Expand Down Expand Up @@ -619,6 +625,8 @@ public final class AuthorizationEndpointConfig {

private AuthorizationRequestRepository<OAuth2AuthorizationRequest> authorizationRequestRepository;

private Converter<OAuth2LoginAuthenticationToken, OAuth2AuthenticationToken> authenticationResultConverter;

private RedirectStrategy authorizationRedirectStrategy;

private AuthorizationEndpointConfig() {
Expand Down Expand Up @@ -663,6 +671,20 @@ public AuthorizationEndpointConfig authorizationRequestRepository(
return this;
}

/**
* Sets the converter responsible for converting from
* {@link OAuth2LoginAuthenticationToken} to {@link OAuth2AuthenticationToken}
* authentication result.
* @param authenticationResultConverter the converter for
* {@link OAuth2AuthenticationToken}'s
*/
public AuthorizationEndpointConfig authenticationResultConverter(
Converter<OAuth2LoginAuthenticationToken, OAuth2AuthenticationToken> authenticationResultConverter) {
Assert.notNull(authenticationResultConverter, "authenticationResultConverter cannot be null");
this.authenticationResultConverter = authenticationResultConverter;
return this;
}

/**
* Sets the redirect strategy for Authorization Endpoint redirect URI.
* @param authorizationRedirectStrategy the redirect strategy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
Expand Down Expand Up @@ -211,6 +212,20 @@ public void oauth2Login() throws Exception {
.hasToString("OAUTH2_USER");
}

@Test
public void oauth2LoginWhenSetAuthenticationResultConverter() throws Exception {
loadConfig(OAuth2LoginConfiguration.class);
OAuth2AuthorizationRequest authorizationRequest = createOAuth2AuthorizationRequest();
this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest, this.request, this.response);
this.request.setParameter("code", "code123");
this.request.setParameter("state", authorizationRequest.getState());
this.springSecurityFilterChain.doFilter(this.request, this.response, this.filterChain);
Authentication authentication = this.securityContextRepository
.loadContext(new HttpRequestResponseHolder(this.request, this.response))
.getAuthentication();
assertThat(authentication).isInstanceOf(CustomOAuth2AuthenticationToken.class);
}

@Test
public void requestWhenCustomSecurityContextHolderStrategyThenUses() throws Exception {
loadConfig(OAuth2LoginConfig.class, SecurityContextChangedListenerConfig.class);
Expand Down Expand Up @@ -754,6 +769,31 @@ public void onApplicationEvent(AuthenticationSuccessEvent event) {

}

@Configuration
@EnableWebSecurity
static class OAuth2LoginConfiguration extends CommonSecurityFilterChainConfig {

@Bean
SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
http.oauth2Login((c) -> c
.authorizationEndpoint((d) -> d
.authenticationResultConverter((r) -> new CustomOAuth2AuthenticationToken(r.getPrincipal(),
r.getAuthorities(), r.getClientRegistration().getRegistrationId())))
.clientRegistrationRepository(new InMemoryClientRegistrationRepository(GOOGLE_CLIENT_REGISTRATION)));
return super.configureFilterChain(http);
}

}

private static class CustomOAuth2AuthenticationToken extends OAuth2AuthenticationToken {

CustomOAuth2AuthenticationToken(OAuth2User principal, Collection<? extends GrantedAuthority> authorities,
String authorizedClientRegistrationId) {
super(principal, authorities, authorizedClientRegistrationId);
}

}

@Configuration
@EnableWebSecurity
static class OAuth2LoginConfigFormLogin extends CommonSecurityFilterChainConfig {
Expand Down