Fix DefaultLoginPageConfigurerTests localization failure on system language different than english #15876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CaptainAye Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@CaptainAye Thank you for signing the Contributor License Agreement! |
…avoid failure when system language is different
CaptainAye
force-pushed
the
fix-login-page-test-localization
branch
from
792b576 to
dcb7c66
Compare
sjohnr
added
in: config
|
Thanks for the PR @CaptainAye! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to fix the
DefaultLoginPageConfigurerTests.loginPageWhenErrorThenDefaultLoginPageWithError()failure given the system language is set to something else than english.When asserting the Bad credentials login page, the expected template contains the hardcoded "Bad credentials" message.
When the system language is other than english, this test fails locally as the actual code will produce the localized version of this page.
This PR fixes the issue adding the localized message to the expected page template in order to make sure that it will match the actual response regardless the locale setting.