Align DelegatingAuthenticationConverter Constructors #15949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Oct 23, 2024
There was a problem hiding this comment.
@kse-music, thanks for this improvement. Please see my inline feedback.
Also, since the constructors demonstrate different behavior, I think this is a bug and should be fixed in 6.3.x as well. Are you able to rebase this change to 6.3.x please?
.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
jzheaux
added
in: web
jzheaux
changed the title
|
Also, @kse-music, I updated the PR title and description to reflect some of the API benefits to this change. |
|
Thanks a lot, @jzheaux. Everything is done as you expected. |
jzheaux
approved these changes
Oct 25, 2024
|
Thanks, @kse-music! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is valuable since
new ArrayList<>()andList.ofhave different behaviors, meaning that these two constructors give two different object states without saying so.This PR aligns the two constructors.