Clarify where "withDefaults()" comes from #16143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfconrey Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@pfconrey Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks, @pfconrey, for the clarification. In preparation for merging, can you please rebase so that there is only one commit in your PR? |
|
After looking through the code base, there are dozens, if not hundreds of locations where this needs to be clarified. I will withdraw this PR and see if there's time to take up making all the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to clarify where "withDefaults()" is defined. It took me a while to figure out how to implement the example in the docs.