Skip to content

Conversation

harpreets789
Copy link
Contributor

This pull request resolves issue #16151 by addressing the dark mode rendering issues on the Cross Site Request Forgery (CSRF) and Method Security documentation pages.

Changes:

  • Added the [.invert-dark] attribute to the .adoc files for the affected pages.
  • Ensured that images now render clearly in both light and dark modes by applying the dark mode CSS styles.

These changes provide a consistent and improved user experience across themes. Feedback and suggestions are welcome!

@pivotal-cla
Copy link

@harpreets789 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2024
@pivotal-cla
Copy link

@harpreets789 Thank you for signing the Contributor License Agreement!

@jzheaux jzheaux changed the title Fix #16151: Add Dark Mode CSS Style for images on CSRF and Method Security pages Add Dark Mode CSS Style for CSRF and Method Security diagrams Nov 25, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 25, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Nov 25, 2024

Hi, @harpreets789, thanks for the fix. Since this occurs in the 6.2.x documentation as well, could you please rebase your PR on 6.2.x? It may also help for you to submit using a PR branch like gh-16151.

Would you also please format your commit so that the ticket is in the body of the commit instead of the title? Something similar to this would be great:

Polish Dark Mode for CSRF and Method Security diagrams

Closes gh-16151

@harpreets789
Copy link
Contributor Author

@jzheaux Thank you for the feedback! I’ll rebase the PR onto the 6.2.x branch and update the commit message as suggested. I’ll also use a new branch (gh-16151) for the submission. Appreciate your guidance!

@harpreets789
Copy link
Contributor Author

harpreets789 commented Nov 25, 2024

Hi, @jzheaux I've created a new branch, gh-16151, rebased on the 6.2.x branch as requested. The changes from this PR have been incorporated into the new branch. A new PR has been opened to reflect these updates: #16166. Please review the new PR. Thank you!

@sjohnr
Copy link
Contributor

sjohnr commented Nov 26, 2024

Closing in favor of gh-16166.

@sjohnr sjohnr closed this Nov 26, 2024
@sjohnr sjohnr self-assigned this Nov 26, 2024
@sjohnr sjohnr added the status: duplicate A duplicate of another issue label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants