Doc: Improve documentation for sessionIdChanged method #16210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@12OneTwo12 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@12OneTwo12 Thank you for signing the Contributor License Agreement! |
|
Hi team, I realize that I should have opened an issue first to discuss this before submitting a pull request. My apologies for not following the proper process! 🙏 To ensure this change aligns with the project's needs, I will close this PR for now and create an issue to start a discussion. Once there is agreement, I will be happy to submit a new PR based on the feedback. Thank you for your understanding, and I appreciate your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This Pull Request refines the comments for the sessionIdChanged method to make its purpose and functionality clearer for contributors and maintainers.
The key updates include:
Providing a more detailed explanation of the method’s role, making it easier to understand.
Clarifying the functionality of the HttpSessionIdChangedEvent, specifically how it captures the old and new session IDs.
Aligning the comments with Spring’s documentation style to improve consistency and readability.
These changes are intended to enhance code clarity and maintainability without affecting any functionality.
Although this is a small improvement, I hope it helps in improving the overall quality of the code. Please feel free to let me know if there are any additional changes you'd like me to make! 😊