Skip to content

Include UsernameNotFoundException in BadCredentialsException #16512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Include UsernameNotFoundException in BadCredentialsException #16512

merged 1 commit into from
Jun 2, 2025

Conversation

big-cir
Copy link
Contributor

@big-cir big-cir commented Jan 31, 2025 •
edited
Loading

Overview

  • Preserve UsernameNotFoundException as cause in BadCredentialsException to improve debuggability during authentication failures.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 31, 2025
@jzheaux jzheaux self-assigned this Feb 3, 2025
jzheaux
jzheaux requested changes May 29, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this one, @big-cir! I've left my feedback inline.

@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 29, 2025
@jzheaux jzheaux added this to the 7.0.x milestone May 29, 2025
@big-cir big-cir force-pushed the fix/include-username-not-found-exception branch 3 times, most recently from 4297f2a to c368ace Compare May 31, 2025 02:54
@big-cir big-cir force-pushed the fix/include-username-not-found-exception branch from c368ace to a8b7adc Compare May 31, 2025 02:56
@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 Jun 2, 2025
@jzheaux jzheaux merged commit 9654e51 into spring-projects:main Jun 2, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jun 2, 2025

Thanks, @big-cir, this is now merged into main.

@big-cir big-cir deleted the fix/include-username-not-found-exception branch June 3, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@big-cir @jzheaux @spring-projects-issues