Skip to content

Correct closing tag in default PassKey HTML form #16601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Correct closing tag in default PassKey HTML form #16601

wants to merge 0 commits into from

Conversation

AB-xdev
Copy link
Contributor

@AB-xdev AB-xdev commented Feb 14, 2025

Fixes #16600

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 14, 2025
@jzheaux jzheaux changed the title DefaultLoginPageGeneratingFilter: PASSKEY_FORM_TEMPLATE - Fixed <div> tag being closed with </form> Fix closing div tag in DefaultLoginPageGeneratingFilter.PASSKEY_FORM_TEMPLATE Mar 7, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 7, 2025
@jzheaux jzheaux self-assigned this Mar 7, 2025
@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Mar 18, 2025
@jzheaux jzheaux changed the base branch from main to 6.4.x March 18, 2025 22:18
@jzheaux jzheaux changed the title Fix closing div tag in DefaultLoginPageGeneratingFilter.PASSKEY_FORM_TEMPLATE Correct closing tag for default PassKey HTML form Mar 18, 2025
@jzheaux jzheaux changed the title Correct closing tag for default PassKey HTML form Correct closing tag in default PassKey HTML form Mar 18, 2025
@jzheaux jzheaux modified the milestones: 6.5.0-RC1, 6.4.5 Mar 18, 2025
@jzheaux jzheaux closed this Mar 18, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Mar 18, 2025

Thanks, @AB-xdev! This is now merged into 6.4.x with d9a937f

@AB-xdev AB-xdev deleted the DefaultLoginPageGeneratingFilter-PASSKEY_FORM_TEMPLATE-invalid-html-tag-closure branch March 19, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ziqin ziqin ziqin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jzheaux jzheaux

Labels

in: web An issue in web modules (web, webmvc) type: bug A general bug

Projects

None yet

Milestone

6.4.5

Development

Successfully merging this pull request may close these issues.

DefaultLoginPageGeneratingFilter: PASSKEY_FORM_TEMPLATE invalid html tag closure

4 participants

@AB-xdev @jzheaux @ziqin @spring-projects-issues