Update HandlerMappingIntrospector Usage in CORS support #16657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
evgeniycheban
force-pushed
the
gh-16501
branch
3 times, most recently
from
f3aadd2 to
2275030
Compare
jzheaux
added
in: config
jzheaux
requested changes
Mar 18, 2025
...main/java/org/springframework/security/config/annotation/web/configurers/CorsConfigurer.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/security/config/annotation/web/configurers/CorsConfigurer.java
Outdated
Show resolved
Hide resolved
jzheaux
added
status: waiting-for-feedback
jzheaux
requested changes
Mar 24, 2025
There was a problem hiding this comment.
Thanks, @evgeniycheban! I think we still need to lookup the CorsConfigurationSource by name, please see my inline comment.
...main/java/org/springframework/security/config/annotation/web/configurers/CorsConfigurer.java
Show resolved
Hide resolved
jzheaux
removed
the
status: waiting-for-feedback
|
@jzheaux I have updated the PR |
Closes spring-projectsgh-16501 Signed-off-by: Evgeniy Cheban <[email protected]>
jzheaux
approved these changes
Mar 26, 2025
...main/java/org/springframework/security/config/annotation/web/configurers/CorsConfigurer.java
Show resolved
Hide resolved
|
Thanks, @evgeniycheban! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16501