Sets correct remote address in WebAuthenticationDetails #16714
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was going trough debug logs of my application on my test server I have noticed this line:
Our application on test server is behind nginx, so because of that attribute
RemoteIpAddressis set to 127.0.0.1 which is wrong...So I have updated WebAuthenticationDetails to read remote address first from
X-Forwarded-For, and then fromX-Real-IPheaders and then finally as fallback to userequest.getRemoteAddr(). This sould cover almost all use cases I guess...