Skip to content

Use HttpStatus in back-channel logout filters #17128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Use HttpStatus in back-channel logout filters #17128

merged 1 commit into from
May 21, 2025

Conversation

@therepanic
Copy link
Contributor

@therepanic therepanic commented May 16, 2025 •
edited
Loading

A couple of classes in the webflux module used the jakarta.servlet module class to specify statuses, which in a way makes us dependent on them and that is wrong. In my fix I used org.springframework.http.HttpStatus

Fixes: #17125

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 16, 2025
@jzheaux jzheaux changed the base branch from main to 6.3.x May 21, 2025 19:17
@jzheaux jzheaux self-assigned this May 21, 2025
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels May 21, 2025
@jzheaux jzheaux added this to the 6.3.10 milestone May 21, 2025
@jzheaux jzheaux changed the title Replace servlet status code with HttpStatus in back-channel logout filters Use HttpStatus in back-channel logout filters May 21, 2025
@jzheaux jzheaux mentioned this pull request May 21, 2025
Closed
@jzheaux jzheaux merged commit 4048b2b into spring-projects:6.3.x May 21, 2025
6 checks passed
@jzheaux jzheaux added type: bug A general bug and removed type: enhancement A general enhancement labels May 21, 2025
@jzheaux
Copy link
Contributor

jzheaux commented May 21, 2025

Thanks, @therepanic! This is now merged into 6.3.x, 6.4.x, 6.5.x, and main

@jzheaux jzheaux mentioned this pull request May 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jzheaux jzheaux

Labels

in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug

Projects

None yet

Milestone

6.3.10

Development

Successfully merging this pull request may close these issues.

OidcBackChannelLogoutWebFilter make use of a servlet class

3 participants

@therepanic @jzheaux @spring-projects-issues