Skip to content

Conversation

ngocnhan-tran1996
Copy link
Contributor

@ngocnhan-tran1996 ngocnhan-tran1996 commented Jun 2, 2025

@rwinch
Copy link
Member

rwinch commented Jun 10, 2025

Thank you for the pull request.

As this pull request is currently created the changelog will say "Polish". This is not a very descriptive entry for a changelog.

Instead, please split this up into multiple pull requests that have titles that are more descriptive.

@rwinch
Copy link
Member

rwinch commented Jun 10, 2025

Closing in favor of multiple pull requests as outlined above.

@rwinch rwinch closed this Jun 10, 2025
@rwinch rwinch self-assigned this Jun 10, 2025
@rwinch rwinch added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2025
@ngocnhan-tran1996 ngocnhan-tran1996 deleted the cleanup branch June 15, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants