Make WebClient.Builder configurable in SpringReactiveOpaqueTokenIntrospector

[therepanic]

This will help us to throw our own WebClient.Builder into SpringReactiveOpaqueTokenIntrospector.Builder with our own parameters that we specify.

Also for this class we have one test where a builder is used. I decided to just throw WebClient.Builder in there in order to use the method, I think it doesn't make much sense to test it, wdyt?

Resolves: #17194

[jzheaux]

Thanks for the suggestion, @therepanic. I'm inclined to leave the class as-is since you can do:

@Bean 
ReactiveOpaqueTokenIntrospector opaqueToken() {
  WebClient.Builder builder = WebClient.builder()
      .defaultHeaders((headers) -> headers.setBasicAuth(clientId, clientSecret))
      // ... your settings
  return new SpringReactiveOpaqueTokenIntrospector(introspectionUri, builder.build());
}

Adding WebClient.Builder to the builder doesn't seem to add much:

@Bean 
ReactiveOpaqueTokenIntrospector opaqueToken() {
  WebClient.Builder builder = WebClient.builder()
      // ... your settings
  return SpringReactiveOpaqueTokenIntrospector.withIntrospectionUri(introspectionUri)
    .clientId(clientId)..clientSecret(clientSecret)
    .build();
}

Will it work for you to construct the WebClient and then pass that into the constructor?

[therepanic]

Yes, I think that will work.

[jzheaux]

Great, @therepanic. I'll close this for now, then. We can always revisit if something comes up.

[pinguet62]

Hello 🖖 @jzheaux

you can do

new SpringReactiveOpaqueTokenIntrospector(introspectionUri, builder.build())

Yes, but

• in this case the header building (setBasicAuth()) is delegated to caller
  while in the actual solution it's responsability of SpringReactiveOpaqueTokenIntrospector & it's builder.
• this constructor is deprecated, isn't it?
  Probably for removable?