Adapt UnboundIdContainer to SmartLifecycle to support ApplicationContext restart
#17546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext restart Closes: spring-projectsgh-17543 Signed-off-by: Andrey Litvitski <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
commented
Jul 17, 2025
Comment on lines
+158
to
+161
| @Override | ||
| public int getPhase() { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Since we don't have anything that we can prioritize, I think neutral as 0 will work fine for us.
|
Thank you for the PR, but this will restart on the same port that was it was initially bound to. This means that we might get a port collision. I'm going to close this as we are still sorting through the best approach with the Framework team. In the meantime, others can follow with #17543 |
rwinch
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnboundIdContainernow implementsSmartLifecycle, which allows Spring TestContext to correctly manage its lifecycle when usingpause()andresume(). Thanks to this,UnboundIdContainerstarts and stops correctly without the need for@DirtiesContext.Closes: gh-17543