Skip to content

Handle AuthorizationDeniedException wrapped in ServletException #17762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
therepanic wants to merge 1 commit into from
Closed

Handle AuthorizationDeniedException wrapped in ServletException #17762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...rc/test/java/org/springframework/security/web/access/ExceptionTranslationFilterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.springframework.security.authentication.AuthenticationTrustResolverImpl;
import org.springframework.security.authentication.BadCredentialsException;
import org.springframework.security.authentication.RememberMeAuthenticationToken;
import org.springframework.security.authorization.AuthorizationDeniedException;
import org.springframework.security.core.AuthenticationException;
import org.springframework.security.core.authority.AuthorityUtils;
import org.springframework.security.core.context.SecurityContext;
Expand Down Expand Up @@ -288,6 +289,20 @@ public void setMessageSourceWhenNotNullThenCanGet() {
verify(source).getMessage(eq(code), any(), any());
}

@Test
public void servletExceptionWrappingAuthorizationDeniedExceptionIsRethrown() throws Exception {
MockHttpServletRequest request = get("/secure/page.html").build();
MockHttpServletResponse response = new MockHttpServletResponse();
FilterChain fc = mockFilterChainWithException(new ServletException(new AuthorizationDeniedException("Denied")));
SecurityContextHolder.getContext()
.setAuthentication(new AnonymousAuthenticationToken("ignored", "ignored",
AuthorityUtils.createAuthorityList("IGNORED")));
ExceptionTranslationFilter filter = new ExceptionTranslationFilter(this.mockEntryPoint);
assertThatExceptionOfType(ServletException.class)
.isThrownBy(() -> filter.doFilter(request, response, fc))
.withCauseInstanceOf(AuthorizationDeniedException.class);
}

private FilterChain mockFilterChainWithException(Exception exception) throws ServletException, IOException {
FilterChain fc = mock(FilterChain.class);
willThrow(exception).given(fc).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class));
Expand Down
Loading