Cleanup #17801
Open
Cleanup #17801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
| if (result.length() == 0) { | ||
| if (result.isEmpty()) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
String result = (query == null) ? "" : artifactPattern.matcher(query).replaceFirst("");
if (result.isEmpty()) {
return null;
}
| * @return | ||
| * @param artifactParameterName the artifactParameterName that is removed from the | ||
| * current URL. The result becomes the service url. Cannot be null and cannot be an | ||
| * empty String. |
There was a problem hiding this comment.
Cannot be null and cannot be an empty String -> Cannot be null or empty String
| return role; | ||
| } | ||
| if (defaultRolePrefix == null || defaultRolePrefix.length() == 0) { | ||
| if (defaultRolePrefix == null || defaultRolePrefix.isEmpty()) { |
There was a problem hiding this comment.
As there are several uses of str == null || str.isEmpty() I think a common util function will be helpful
boolean isEmpty(String str) {
return str == null || str.length == 0;
}
There was a problem hiding this comment.
I think we can use !org.springframework.util.StringUtils#hasLength
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
ngocnhan-tran1996
force-pushed
the
cleanup
branch
from
ec9b7b9 to
f77e0b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
StringUtils#hasLength