Skip to content

Conversation

therepanic
Copy link
Contributor

Closes: gh-17963

@therepanic
Copy link
Contributor Author

therepanic commented Sep 30, 2025

I believe that the current implementation is early and we can still change it, but I have provided an example of how it might look.

By the way, I have a couple of questions.

In #17963, what was meant by:

NOTE: findAdditionalAuthorities should use a mapper object of sorts that can swap out. It can return some constants if the SQL returns true or it can look up the additional authorities in SQL.

In the current implementation, we use whenTrueMode in findAdditionalAuthorities as a signal for how to process the SQL provided to us. How would this look more correctly with a mapper object?

Also, how should we do the tests? Are there already existing tests in spring-security where we test the class that uses DataSource? Should we do an integration test?

@rwinch rwinch self-assigned this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create SqlAllAuthoritiesAuthorizationManager
3 participants