Honor @Primary for UserDetailsService and UserDetailsPasswordService in InitializeUserDetailsBeanManagerConfigurer #18015
+213
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In scenarios where multiple
UserDetailsService
orUserDetailsPasswordService
beansare defined, Spring may raise
NoUniqueBeanDefinitionException
or select the wrongbean without explicit resolution.
Changes
@Primary
toUserDetailsService
andUserDetailsPasswordService
beans inInitializeUserDetailsBeanManagerConfigurer
Issue Reference
Fixes gh-17902
Testing
InitializeUserDetailsBeanManagerConfigurerTests
to validateresolution when multiple candidates are present
./gradlew check
Notes