Remove deprecated HttpComponents5Connection usage #1497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `HttpComponents5Connection` would use deprecated methods from `HttpClient`. This commit updates the deprecated `execute` in favor of `executeOpen`, while checking that the response resource is properly closed when the call is done. Fixes spring-projectsgh-1469 Signed-off-by: Brian Clozel <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: task
|
Given that this changes the signature of a constructor, let's do that in 4.1.x |
|
Fixed by d7524e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
HttpComponents5Connectionwould use deprecated methods fromHttpClient. This commit updates the deprecatedexecutein favor ofexecuteOpen, while checking that the response resource is properly closed when the call is done.Fixes gh-1469