fix: webpack import meta error #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
gopher-docs-preview (Preview)
MakMuftic
approved these changes
Jan 6, 2025
Member
|
@saadahmsiddiqui just rebase this to the latest |
…bpack-import-meta-error
Contributor
Author
|
rebased |
github-actions
bot
temporarily deployed
to
gopher-docs-preview (Preview)
Tbaut
approved these changes
Jan 9, 2025
Contributor
Tbaut
left a comment
Tbaut
left a comment
There was a problem hiding this comment.
Just saw the warning in the build process, lgtm
github-actions
bot
temporarily deployed
to
gopher-docs-preview (Preview)
Merged
Tbaut
added a commit
that referenced
this pull request
Jan 16, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>docs: 1.0.0</summary> ## [1.0.0](docs-v0.0.1...docs-v1.0.0) (2025-01-13) ### ⚠ BREAKING CHANGES * All functions renamed, different API and flows, please consult docs or reach out to us directly! ### Features * add enableSwaps in `transferWithHook` and `transfer` ([#97](#97)) ([bd21311](bd21311)), closes [#94](#94) * add relay to the docs ([#103](#103)) ([310c506](310c506)) * Add sweep function ([#115](#115)) ([efaaa2b](efaaa2b)), closes [#110](#110) * cross chain contract call ([#21](#21)) ([69c0128](69c0128)) * depricate provider param from sdk ([#41](#41)) ([72297fe](72297fe)) * docs POC ([#14](#14)) ([8cd800d](8cd800d)) * dynamic supported network and tokens in docs ([#32](#32)) ([abe5618](abe5618)), closes [#29](#29) * erc20 with contract call ([#39](#39)) ([77e1d8d](77e1d8d)), closes [#38](#38) * native tokens transfers ([#40](#40)) ([d4edf35](d4edf35)), closes [#36](#36) * refactor api ([#61](#61)) ([d6b1e9c](d6b1e9c)) </details> <details><summary>sprinter-sdk: 1.2.0</summary> ## [1.2.0](sprinter-sdk-v1.1.2...sprinter-sdk-v1.2.0) (2025-01-13) ### Features * Add sweep function ([#115](#115)) ([efaaa2b](efaaa2b)), closes [#110](#110) ### Bug Fixes * webpack import meta error ([#114](#114)) ([f5f6fcf](f5f6fcf)) </details> <details><summary>sprinter-react: 1.2.0</summary> ## [1.2.0](sprinter-react-v1.1.2...sprinter-react-v1.2.0) (2025-01-13) ### Features * Add sweep function ([#115](#115)) ([efaaa2b](efaaa2b)), closes [#110](#110) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Thibaut Sardan <[email protected]>
This was referenced Jan 21, 2025
Closed
Merged
BeroBurny
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>docs: 0.1.0</summary> ## [0.1.0](docs-v0.0.1...docs-v0.1.0) (2025-01-21) ### Features * Add sweep function ([#115](#115)) ([efaaa2b](efaaa2b)), closes [#110](#110) ### Bug Fixes * `package.json` - repository ([#127](#127)) ([21c7007](21c7007)) </details> <details><summary>sprinter-sdk: 1.2.0</summary> ## [1.2.0](sprinter-sdk-v1.1.2...sprinter-sdk-v1.2.0) (2025-01-21) ### Features * Add sweep function ([#115](#115)) ([efaaa2b](efaaa2b)), closes [#110](#110) * expand bridge transaction history using relay API ([#122](#122)) ([06ca1a0](06ca1a0)) ### Bug Fixes * `package.json` - repository ([#127](#127)) ([21c7007](21c7007)) * webpack import meta error ([#114](#114)) ([f5f6fcf](f5f6fcf)) </details> <details><summary>sprinter-react: 1.2.0</summary> ## [1.2.0](sprinter-react-v1.1.2...sprinter-react-v1.2.0) (2025-01-21) ### Features * Add sweep function ([#115](#115)) ([efaaa2b](efaaa2b)), closes [#110](#110) ### Bug Fixes * `package.json` - repository ([#127](#127)) ([21c7007](21c7007)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some investigation about this and it turns out our transpiled JS code is the following (published package)
here import.meta is accessed directly, however https://webpack.js.org/api/module-variables/ states that you cannot directly access import.meta instead, access its properties or de-structure it
I believe this affects all projects using webpack and we might need to update the code for this function