fix: add make fetch options to poolAssetOnDestination, poolAssetOnDestinationWithHook, transfer
#79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DestinationWithHook`, `transfer`
github-actions
bot
temporarily deployed
to
gopher-docs-preview (Preview)
BeroBurny
suggested changes
Nov 14, 2024
Contributor
BeroBurny
left a comment
BeroBurny
left a comment
There was a problem hiding this comment.
To make it more clean use only makeFetchOptions idea for it is to reduce if else's like done in this code
I think it will be good to make parametar options optional for makeFetchOptions
|
|
github-actions
bot
temporarily deployed
to
gopher-docs-preview (Preview)
Contributor
Author
updated with changes |
BeroBurny
approved these changes
Nov 14, 2024
Merged
saadahmsiddiqui
pushed a commit
that referenced
this pull request
Nov 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>sprinter-sdk: 1.0.1</summary> ## [1.0.1](sprinter-sdk-v1.0.0...sprinter-sdk-v1.0.1) (2024-11-15) ### Bug Fixes * add make fetch options to `poolAssetOnDestination`, `poolAssetOnDestinationWithHook`, `transfer` ([#79](#79)) ([2883aa7](2883aa7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
saadahmsiddiqui
pushed a commit
that referenced
this pull request
Nov 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>sprinter-sdk: 1.0.1</summary> ## [1.0.1](sprinter-sdk-v1.0.0...sprinter-sdk-v1.0.1) (2024-11-21) ### Bug Fixes * add make fetch options to `poolAssetOnDestination`, `poolAssetOnDestinationWithHook`, `transfer` ([#79](#79)) ([2883aa7](2883aa7)) * trigger missed release ([#87](#87)) ([db8d8d8](db8d8d8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprinter react SDK doesn't call testnet API even when testnet
baseUrlhas been provided to the context