Skip to content

Conversation

@Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Nov 25, 2024

Some nits as I've seen this code for the first time:

  • adapt the readme so that newcomers know what to do (e.g build the sprinter-sdk package first)
  • fix a typo where all the "quotes" were called "quota"
  • there are many TS errors here and there, and I just fixed some of them as I was browsing the code

@Tbaut Tbaut requested review from BeroBurny and MakMuftic November 25, 2024 11:59
@Tbaut Tbaut changed the title Fix readme, some errors and other nits fix(): readme, some errors and other nits Nov 25, 2024
@Tbaut Tbaut changed the title fix(): readme, some errors and other nits fix(PoC): readme, some errors and other nits Nov 25, 2024
@github-actions github-actions bot temporarily deployed to gopher-poc (Preview) November 25, 2024 14:02 Inactive
@github-actions github-actions bot temporarily deployed to gopher-docs-preview (Preview) November 25, 2024 14:03 Inactive
@BeroBurny BeroBurny merged commit f4fb199 into master Dec 3, 2024
2 checks passed
@BeroBurny BeroBurny deleted the tbaut-nits branch December 3, 2024 03:20
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
mpetrunic pushed a commit that referenced this pull request Dec 11, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>sprinter-sdk: 1.1.0</summary>

##
[1.1.0](sprinter-sdk-v1.0.2...sprinter-sdk-v1.1.0)
(2024-12-11)


### Features

* add enableSwaps in `transferWithHook` and `transfer`
([#97](#97))
([bd21311](bd21311)),
closes [#94](#94)
</details>

<details><summary>sprinter-react: 1.1.0</summary>

##
[1.1.0](sprinter-react-v1.0.0...sprinter-react-v1.1.0)
(2024-12-11)


### Features

* add enableSwaps in `transferWithHook` and `transfer`
([#97](#97))
([bd21311](bd21311)),
closes [#94](#94)


### Bug Fixes

* **PoC:** readme, some errors and other nits
([#90](#90))
([f4fb199](f4fb199))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants