feat: unlock API #73
Merged
feat: unlock API #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrun5
requested review from
MakMuftic,
mpetrunic,
nmlinaric and
tcar121293
as code owners
|
Go Test coverage is 54.9 %\ ✨ ✨ ✨ |
mpetrunic
reviewed
Oct 6, 2025
| return nil, err | ||
| } | ||
|
|
||
| err = h.coordinator.Execute(context.Background(), []tss.TssProcess{signing}, data.SigChn, data.Coordinator) |
Member
There was a problem hiding this comment.
why doesn't handleMessage func take context?
Collaborator
Author
There was a problem hiding this comment.
The code of message handlers is old.
I would have to change it in the core library and in all the other handlers.
mpetrunic
approved these changes
Oct 6, 2025
MakMuftic
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue Or Context
Closes: #52
How Has This Been Tested? Testing details.
Types of changes
Checklist: