Skip to content

fix: remove 0x #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpetrun5 merged 1 commit into from
Oct 10, 2025
Merged

fix: remove 0x #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol/lifi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func NewLifiAPI() *LifiAPI {

// GetOrder fetches order from the LiFi API by its on-chain orderID
func (a *LifiAPI) GetOrder(orderID string) (*lifi.LifiOrder, error) {
url := fmt.Sprintf("%s/orders/status?onChainOrderId=0x%s", LIFI_URL, orderID)
url := fmt.Sprintf("%s/orders/status?onChainOrderId=%s", LIFI_URL, orderID)
resp, err := a.HTTPClient.Get(url)
if err != nil {
return nil, fmt.Errorf("request failed: %w", err)
Expand Down
2 changes: 1 addition & 1 deletion protocol/lifi/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func Test_LifiAPI_GetOrder(t *testing.T) {
t.Run(tc.name, func(t *testing.T) {
client := lifi.NewLifiAPI()
client.HTTPClient.Transport = roundTripperFunc(func(req *http.Request) (*http.Response, error) {
expectedURL := fmt.Sprintf("%s/orders/status?onChainOrderId=0x%s", lifi.LIFI_URL, tc.id)
expectedURL := fmt.Sprintf("%s/orders/status?onChainOrderId=%s", lifi.LIFI_URL, tc.id)
if req.URL.String() != expectedURL {
return nil, fmt.Errorf("unexpected URL: got %s, want %s", req.URL.String(), expectedURL)
}
Expand Down
Loading