Skip to content

fix: use tx hash from lifi api #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpetrun5 merged 2 commits into from
Oct 13, 2025
Merged

fix: use tx hash from lifi api #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df0bad6
fix: use tx hash from lifi api
mpetrun5 Oct 13, 2025
a969836
Fix tests
mpetrun5 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chains/evm/message/confirmations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (w *Watcher) wait(ctx context.Context, txHash common.Hash, requiredConfirma
for {
select {
case <-ctx.Done():
return fmt.Errorf("timed out waiting for confirmations")
return fmt.Errorf("timed out waiting for confirmations %s", txHash.Hex())
default:
txReceipt, err := w.client.TransactionReceipt(ctx, txHash)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion chains/evm/message/lifiEscrow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func (h *LifiEscrowMessageHandler) HandleMessage(m *message.Message) (*proposal.
err = h.confirmationWatcher.WaitForOrderConfirmations(
context.Background(),
h.chainID,
common.HexToHash(data.DepositTxHash),
*order.Meta.OrderInitiatedTxHash,
orderValue,
)
if err != nil {
Expand Down
3 changes: 1 addition & 2 deletions chains/evm/message/lifiEscrow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,11 @@ func (s *LifiEscrowMessageHandlerTestSuite) Test_HandleMessage_ValidOrder() {
LiquidityPool: common.HexToAddress("0xe59aaf21c4D9Cf92d9eD4537f4404BA031f83b23"),
BorrowAmount: big.NewInt(10000),
OrderID: "orderID",
DepositTxHash: "0xhash",
}
s.mockOrderFetcher.EXPECT().GetOrder("orderID").Return(s.mockOrder, nil)
s.mockOrderValidator.EXPECT().Validate(s.mockOrder).Return(nil)
s.mockOrderPricer.EXPECT().PriceInputs(gomock.Any()).Return(float64(1000), nil)
s.mockWatcher.EXPECT().WaitForOrderConfirmations(gomock.Any(), uint64(8453), common.HexToHash(ad.DepositTxHash), float64(1000)).Return(nil)
s.mockWatcher.EXPECT().WaitForOrderConfirmations(gomock.Any(), uint64(8453), gomock.Any(), float64(1000)).Return(nil)
s.mockCoordinator.EXPECT().Execute(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil)

m := &coreMessage.Message{
Expand Down
Loading