Rework entrypoint to deprecate some variables #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frebib
requested changes
Apr 30, 2024
| >&2 printf "txadmin does not use the \$LICENSE_KEY environment variable.\nPlease remove it and set it through the txadmin web UI\n\n" | ||
| exit 1 | ||
| # Set some default options. | ||
| if [ -z "${NO_DEFAULT_CONFIG}" ]; then |
Member
There was a problem hiding this comment.
If NO_TXADMIN is set explicitly by the user, we shouldn't do this
frebib
force-pushed
the
master
branch
4 times, most recently
from
c81a042 to
5a06418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs deprecation warning for NO_LICENSE_KEY, & LICENSE_KEY (and gentle prods towards the associated config options)