Add mdoc constructor for IssuerSignedDehydrated and NameSpacedData data #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanmtate
force-pushed
the
feat/cbor-bytes-issuer-signed-mdoc-constructor
branch
from
ae07c61 to
d9d0cfa
Compare
Contributor
Author
|
depends on spruceid/isomdl#117 |
…for cbor bytes Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
feat/cbor-bytes-issuer-signed-mdoc-constructor
branch
from
d9d0cfa to
efda999
Compare
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
changed the title
sbihel
approved these changes
Jan 28, 2026
Co-authored-by: Simon Bihel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the
Mdoccredential handling in the Rust codebase, focusing on improved interoperability and testability. The main changes introduce a new constructor for creatingMdocinstances from CBOR-encoded issuer-signed data and add a comprehensive test to ensure correct CBOR parsing and object construction. Additionally, the dependency on theisomdlcrate is updated for compatibility and feature improvements.New functionality and test coverage:
Mdocconstructor,new_from_cbor_encoded_issuer_signed, allowing direct creation of anMdocfrom CBOR-encoded issuer-signed bytes, improving interoperability with external data sources.IssuerSignedobject, and constructs anMdoc, verifying the new constructor and CBOR parsing logic.Dependency updates:
isomdlcrate dependency to a newer commit (7959c8b), ensuring compatibility with the latest features and bug fixes.