Conversation
Juliano1612
approved these changes
Jan 29, 2026
Member
Juliano1612
left a comment
There was a problem hiding this comment.
LGTM!
Question: sd_hash should be validated automatically during .decode_kb().verify() or should we let it for the caller?
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings support for an optional key binding JWT in the
SdJwttype. I decided to go with an optional KB instead of a brand newSdJwtKbtype because it seemed more flexible in the case a KB is not required by the audience.Other changes
I added a few convenience functions/methods to JWT claims, so they can be verified more easily.
Tested
You will find two new tests in the
kbmodule. One builds, signs and verify an SD-JWT+KB, while the other tries to verify an external SD-JWT+KB (found in the spec).