[WIP] PR: Support multiple files in remote file explorer & other improvements (Files) #25522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
force-pushed
the
multiple-files-in-remote-explorer
branch
7 times, most recently
from
d75ce94 to
b8d57e9
Compare
ccordoba12
force-pushed
the
multiple-files-in-remote-explorer
branch
16 times, most recently
from
701e853 to
e51b63c
Compare
ccordoba12
changed the title
- This happens when closing Spyder, there are two consoles, one local and one remote, and the focus is on the local one. - In that case a signal to change the cwd is emitted for the local directory, which doesn't exist for the remote one and generates the error.
We were doing that line by line, which is quite slow even for small files.
…e exist This prevents overwriting remote files unconditionally, i.e. without asking the user first they really want to do it.
Also, break copy and paste into two different operations to be able to copy files to directories other than the current one.
- This makes the UX for both widgets more consistent. - Also, rename "Copy path" to "Copy absolute path" for consistency.
ccordoba12
force-pushed
the
multiple-files-in-remote-explorer
branch
4 times, most recently
from
c5c04f8 to
0530581
Compare
Also, fix issues that were found by the new tests.
Also, add a test that checks that.
- Now errors are handled in the slots connected to async functions, instead of doing it directly in those functions. - A QMessageBox was shown when requesting downloads, which can lead to segfaults because it was done inside async code. - Abort downloading files if the user doesn't select a download directory.
This prevents an error that happens sometimes when manually closing a connection.
…-services.git --branch=raise-errors --update --force external-deps/spyder-remote-services subrepo: subdir: "external-deps/spyder-remote-services" merged: "fefb785a53" upstream: origin: "https://github.com/ccordoba12/spyder-remote-services.git" branch: "raise-errors" commit: "fefb785a53" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "ea10886"
CAM-Gerlach
changed the title
ccordoba12
force-pushed
the
multiple-files-in-remote-explorer
branch
from
0530581 to
d05e96a
Compare
Also, add test that checks that.
ccordoba12
force-pushed
the
multiple-files-in-remote-explorer
branch
from
ee4252c to
062989c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
RemoteExplorerwidget.66 bytesor490 KiB, instead of showing all sizes in bytes.Delto delete files).Uploadaction toRemoteExplorercontext menu.Visual changes
TODO
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: