fix: MySQL parameter binding compatibility with SQLAlchemy #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert MySQL '?' placeholders to named parameters (':p1', ':p2', etc.)
for proper SQLAlchemy parameter binding
- Add MySQL type mapping support for Python type inference
- Fix SQL syntax error when using generated code with MySQL + SQLAlchemy
The generated code was using '?' placeholders in SQL but passing named
parameters as dictionaries, which caused MySQL syntax errors. This fix
ensures the SQL uses named parameters that match the parameter binding.
Fixes parameter binding issues for MySQL users of sqlc-gen-python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code was using '?' placeholders in SQL but passing named parameters as dictionaries, which caused MySQL syntax errors. This fix ensures the SQL uses named parameters that match the parameter binding.
Fixes parameter binding issues for MySQL users of sqlc-gen-python.