fix: Support multi-argument version of unnest #3738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `sqlc` errors out when it encounters the multi-argument version of the `UNNEST` function. This is because the function is not marked as variadic. Instead, the argument type is defined as [`anymultirange`](https://www.postgresql.org/docs/current/extend-type-system.html#EXTEND-TYPES-POLYMORPHIC). Fixes sqlc-dev#3507 Signed-off-by: Charith Ellawala <[email protected]>
Signed-off-by: Charith Ellawala <[email protected]>
|
Not sure why the managed-db tests fail and how to go about debugging them 🤔 |
Signed-off-by: Charith Ellawala <[email protected]>
|
@kyleconroy Do you have a chance to review this PR? I believe this works well and would go nicely with some recent improvements. |
|
Is there any change to review this PR please? It's been almost a year |
|
@kyleconroy just a kind reminder, it would be highly appreciated if you will find some time to review this PR. Thanks a lot in advance! 👍 |
|
@andrewmbenton PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
sqlcerrors out when it encounters the multi-argument version of theUNNESTfunction. This is because the function is not marked as variadic. Instead, the argument type is defined asanymultirange.Fixes #3507