Skip to content

fix(sqlite): Removed ToLower in typecast #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(sqlite): Removed ToLower in typecast #3860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feab13e
fix(sqlite): removed ToLower in typecast
giuliano-macedo Feb 25, 2025
66cf32b
refact(sqlite): more expecific variable name
giuliano-macedo Feb 25, 2025
9dd4b9d
tests(sqlite): cast param with override
giuliano-macedo Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions internal/endtoend/testdata/cast_param_with_override/sqlite/go/db.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions internal/endtoend/testdata/cast_param_with_override/sqlite/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 44 additions & 0 deletions internal/endtoend/testdata/cast_param_with_override/sqlite/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/endtoend/testdata/cast_param_with_override/sqlite/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- name: GetData :many
SELECT baz, CAST(max(bar) AS REAL) AS result FROM foo;
4 changes: 4 additions & 0 deletions internal/endtoend/testdata/cast_param_with_override/sqlite/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
CREATE TABLE foo (
bar REAL NOT NULL,
baz INTEGER NOT NULL
);
18 changes: 18 additions & 0 deletions internal/endtoend/testdata/cast_param_with_override/sqlite/sqlc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "sqlite",
"schema": "schema.sql",
"queries": "query.sql",
"name": "querytest",
"overrides": [
{
"db_type": "REAL",
"go_type": "github.com/sqlc-dev/sqlc-testdata/pkg.CustomType"
}
]
}
]
}
6 changes: 3 additions & 3 deletions internal/engine/sqlite/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,13 +1073,13 @@ func (c *cc) convertBetweenExpr(n *parser.Expr_betweenContext) ast.Node {
}

func (c *cc) convertCastExpr(n *parser.Expr_castContext) ast.Node {
name := n.Type_name().GetText()
typeName := n.Type_name().GetText()
return &ast.TypeCast{
Arg: c.convert(n.Expr()),
TypeName: &ast.TypeName{
Name: name,
Name: typeName,
Names: &ast.List{Items: []ast.Node{
NewIdentifier(name),
&ast.String{Str: typeName},
}},
ArrayBounds: &ast.List{},
},
Expand Down
Loading