Add support for order by in aggregate functions for sqlite3 #4132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://sqlite.org/lang_aggfunc.html group_concat and string_agg support order by clause inside them
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sqlite.org/lang_aggfunc.html
group_concat and string_agg support order by clause inside them
Let me know if anything needs to be changed before merging this because I didn't find any contribution guide and tried my best to assume how to approach it.
I left aggregate_function_invocation definition in SQLiteParser.g4 unchanged because I didn't find any place where it's used so I decided to just not touch it I guess. But if it will be user somewhere it the future that should fixed as well.