Skip to content

Add cross platform builds #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcobambini merged 42 commits into from
Jul 23, 2025
Merged

Add cross platform builds #1

marcobambini merged 42 commits into from
Jul 23, 2025

Conversation

@danielebriggi
Copy link
Member

@danielebriggi danielebriggi commented Jul 17, 2025

No description provided.

Gioee and others added 30 commits July 17, 2025 15:24
@Gioee
Update .gitignore, add main.yml workflow, and create Makefile for SQL…
87cd26a 
…ite AI extension. Add needed SQLITE_EXTENSION_INIT3 in utils.c.
@Gioee
Enable submodule checkout in GitHub Actions workflow
51ab3ba
@Gioee
Update Makefile to use available CPU cores for building libraries
0e86213
@Gioee
Update Makefile for macOS fat library support
6fa5eb3
@Gioee
Update Makefile for improved macOS, iOS and iSIM support
837c482
@Gioee
Enable BLAS support for Linux platform in Makefile
cf78a12
@Gioee
Update Makefile to remove unnecessary ggml-blas references and ensure…
2e4be01 
… proper linking only for macOS
@Gioee
Update Makefile to enhance library linking and deployment targets for…
1413190 
… macOS, iOS, iSIM and Linux
@Gioee
Update Makefile to improve library linking for LLAMA and WHISPER, and…
0bf7e25 
… enhance platform-specific options for macOS, iOS, Android, Linux and iSIM
@Gioee
Fix Makefile build submodules on Windows
346c7c1
@Gioee
Update Makefile to enable position-independent code for LLAMA and WHI…
6b72907 
…SPER on Android platform
@Gioee
Fix test command in Makefile to load the correct AI module from the d…
0439ecf 
…ist directory
@Gioee
Update Makefile for Android platform to include toolchain and archite…
2c5eb69 
…cture-specific flags
@Gioee
Update Makefile for Android platform to adjust architecture-specific …
b8fa193 
…flags
@Gioee
Update Makefile and GitHub Actions workflow for Windows compatibility
f0e0c59
@Gioee
Update Makefile for Android platform to adjust architecture-specific …
ebdbacb 
…flags for x86-64
@Gioee
Add separate build step for Windows in GitHub Actions workflow
4ada3fb
@Gioee
Add CMake installation for Windows build in GitHub Actions workflow
9d4bcd6
@Gioee
Update Makefile to enable Vulkan and OpenMP for Linux builds
6dbfe2f
@Gioee
Remove Vulkan option from Linux build in Makefile
e45515b
@Gioee
Remove OpenSSL folder cleanup from Android build process
24f4d01
@Gioee
Enable CoreML support in macOS and iOS builds in Makefile
68c1bef
@Gioee
Cleanup unused folders in Android test process to save space and avoi…
add42b2 
…d emulator errors
@Gioee
Update Makefile to enable static linking for Android builds and add d…
a6adb84 
…ebug symbol stripping to reduce target size
@Gioee
Add stripping of debug symbols for platform-specific builds in Makefile
ac17185
@Gioee
Update GitHub Actions workflow to include Vulkan installation for Lin…
2948628 
…ux builds and adjust Makefile for LLAMA and WHISPER user defined options
feat(linux): safe resource free up
6733444 
- Linux x86_64 build setup
fix(windows): missing git
048463a
fix(windows): missing codecvt link
b32c573
chore(windows): detecting fix for make test
b5fdbe4
@danielebriggi
Copy link
Member Author

danielebriggi commented Jul 17, 2025 •
edited
Loading

@Gioee
I report here an improvement I asked to GPT and I agree on for the strip step:

- Stripping is usually done as a final step for release/distribution, not for testing/debugging.
- For best practice, you should:
   - Build the DLL.
   - (Optionally) run tests on the unstripped DLL (so you get better error messages and stack traces).
  - Strip the DLL only for packaging/distribution.
 
Current Makefile behavior:

- The DLL is stripped immediately after building, before running the test.
- This means the test uses the stripped DLL, which is not ideal for debugging.

How to improve:

- Move the $(STRIP) step to a separate target, e.g., strip or release.
- The test target should use the unstripped DLL.
- Only strip when you explicitly want a release build.

Summary:
The current Makefile strips the DLL before testing, which is not best practice. It would be better to strip only for release, not for test/debug.

I asked for it because I saw that the windows build is stripping the ddl before running the make test step which is kind of weird:
image

@danielebriggi danielebriggi force-pushed the add-cross-platform-builds branch from 90fbfdc to 73eee5d Compare July 17, 2025 13:44
@danielebriggi danielebriggi force-pushed the add-cross-platform-builds branch from 73eee5d to a049445 Compare July 17, 2025 13:46
@danielebriggi danielebriggi force-pushed the add-cross-platform-builds branch from 0d142ee to 2597117 Compare July 17, 2025 14:07
@danielebriggi danielebriggi force-pushed the add-cross-platform-builds branch 5 times, most recently from 063bd4b to 76c1165 Compare July 17, 2025 15:17
@danielebriggi danielebriggi force-pushed the add-cross-platform-builds branch 9 times, most recently from 75fa13a to 1cd6df0 Compare July 18, 2025 11:02
@danielebriggi danielebriggi force-pushed the add-cross-platform-builds branch from 1cd6df0 to 08d53d7 Compare July 18, 2025 12:03
@marcobambini marcobambini merged commit b6be2c3 into main Jul 23, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcobambini marcobambini marcobambini approved these changes

Assignees

@danielebriggi danielebriggi

@Gioee Gioee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danielebriggi @marcobambini @Gioee