Skip to content

Conversation

lovasoa
Copy link
Collaborator

@lovasoa lovasoa commented Sep 17, 2025

Split OIDC state cookie into two separate cookies to prevent race conditions during concurrent login flows.

Previously, a single sqlpage_oidc_state cookie was used to store both the nonce and the redirect URL. When multiple OIDC login flows were initiated simultaneously in the same browser, this cookie would be overwritten, leading to authentication failures and loss of the intended redirect target. This change introduces a sqlpage_oidc_nonce cookie for the nonce and a short-lived, state-specific sqlpage_oidc_state_{csrf_token} cookie for the redirect URL, ensuring each login flow maintains its unique state.


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Sep 17, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@lovasoa lovasoa marked this pull request as ready for review September 19, 2025 09:36
@lovasoa lovasoa merged commit a451c7e into main Sep 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants