-
-
Notifications
You must be signed in to change notification settings - Fork 154
The login component is an authentication form for users of an application #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! I'm ready to merge this new component, but I think we need to make a few changes first.
<span class="input-icon-addon"> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" | ||
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" | ||
stroke-linecap="round" stroke-linejoin="round" | ||
class="icon icon-tabler icons-tabler-outline icon-tabler-lock"> | ||
<path stroke="none" d="M0 0h24v24H0z" fill="none"/> | ||
<path d="M5 13a2 2 0 0 1 2 -2h10a2 2 0 0 1 2 2v6a2 2 0 0 1 -2 2h-10a2 2 0 0 1 -2 -2v-6z" /> | ||
<path d="M11 16a1 1 0 1 0 2 0a1 1 0 0 0 -2 0" /> | ||
<path d="M8 11v-4a4 4 0 1 1 8 0v4" /> | ||
</svg> | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use the built-in tabler icons like in the other components instead of inlining the svg ?
<span class="input-icon-addon"> | ||
<svg xmlns="http://www.w3.org/2000/svg" class="icon" width="24" | ||
height="24" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" | ||
fill="none" stroke-linecap="round" stroke-linejoin="round"> | ||
<path stroke="none" d="M0 0h24v24H0z" fill="none" /> | ||
<circle cx="12" cy="7" r="4" /> | ||
<path d="M6 21v-2a4 4 0 0 1 4 -4h4a4 4 0 0 1 4 4v2" /> | ||
</svg> | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use builtin tabler icons like in the other components ? And maybe make the icon configurable ?
'login', | ||
'Using the main options of the login component', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we describe it in a little more details ? Ideally, provide a sql code block with example validation code used to actually log the user in and create a session.
Maybe get inspiration from https://sql-page.com/component.sql?component=authentication ? Some users need handholding, especially for scare high-stakes tasks like implementing an authentication mechanism. Showing the docs for the UI without some explanation about how to make it secure on the backend would probably lead to people implementing insecure auth.
It allows the entry of a user account consisting of a username and a password.
It offers additional features such as the ability to request session persistence or to reset the password.