Skip to content

Conversation

@a-gonzalo
Copy link
Contributor

As discussed in #1120 .

Pending to test and document. First try.

Also, like 1 year ago I started working on an accordion component. I think I didn't make a pull request and I don't know if someone implemented it. I'll check it out and remove the changes if it is done.

@a-gonzalo a-gonzalo marked this pull request as draft November 29, 2025 17:21
@a-gonzalo
Copy link
Contributor Author

@lovasoa I think I will need to test it with something like MinIO and make some docs.
Do you miss anything related with this?

Also, I would appreciate if you check the commit for the test "run_all_sql_test_files" commit1 commit2

@lovasoa
Copy link
Collaborator

lovasoa commented Nov 30, 2025

Hi !
Thanks for taking a stab at this !
This is a large PR and I am currently quite busy so it may take some time, but here are my initial remarks:

  • we need a single well tested and well documented feature per PR
    • in this case we need tests that exercise upload / download against an open source s3 implementation
    • the ci times should not increase too much
  • adding new dependencies is costly, we need some reassurance about: compiled binary size increase, compile time increase, how well the dependencies are maintained
  • the documentation needs to be available on the official site
  • i'm not a huge fan of interpreting the same argument as either a file path or a base64 string. If a file has a name that is a valid base64 string, it can get uploaded instead of base64 data.
  • no custom bespoke security rules. I don't think we should forbid uploading files outside the web root. On the contrary it should be encouraged.
  • I think the user should be able to upload to different buckets let them provide s3://{bucket}/{key}, not just key.

@kryskool
Copy link
Contributor

kryskool commented Dec 3, 2025

Hi @a-gonzalo

Instead of MinIO (MinIO just move in maintenance mode ) , maybe we can use RustFS

Regards,

@lovasoa
Copy link
Collaborator

lovasoa commented Dec 4, 2025

I'm not sure RustFS is production-ready...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants