Skip to content

Pull request to add robots.txt and sitemap.xml files (v1) #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Pull request to add robots.txt and sitemap.xml files (v1) #643

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
018c186
Add pricing file
alexisrc1 Sep 4, 2024
cbb2e2d
Merge remote-tracking branch 'upstream/main'
alexisrc1 Sep 22, 2024
2335856
Merge remote-tracking branch 'upstream/main'
alexisrc1 Oct 9, 2024
5fbc879
Add robots.txt and sitemap.xml for SEO
alexisrc1 Oct 10, 2024
78dea52
Update file1 and file2 with new changes
alexisrc1 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions examples/official-site/robots.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
User-agent: *
Disallow: /examples/authentification/ # Block the folder "authentification" to avoid blocking by password
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do not block the entire authentication example ? We still want it referenced. Ideally change the auth example so the password protected page has a different url, that you can block

Disallow: /examples/hash_password.sql # Block access to specific sensitive SQL files like this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ? This is a useful page, it is not password protected: https://sql.datapage.app/examples/hash_password.sql

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one is ?

Disallow: /Dockerfile # Block access to Dockerfile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ? https://sql.datapage.app/Dockerfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was told to limit the number of files that need to be crawled so I figure this one is not useful for Google

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the link. The file does not exist


Allow: / # Allow access to all public-facing SQL-generated pages

Sitemap: https://sql.datapage.app/sitemap.xml
23 changes: 23 additions & 0 deletions examples/official-site/sitemap.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url>
<loc>https://sql.datapage.app/</loc>
<lastmod>2024-10-10</lastmod>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to hardcode the date like this ? Won't the prevent re-crawling when we update the page ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it remains hard coded for too long it is an issue, for this first try it is ok

<priority>1.00</priority>
</url>
<url>
<loc>https://sql.datapage.app/component.sql</loc>
<lastmod>2024-10-10</lastmod>
<priority>0.80</priority>
</url>
<url>
<loc>https://sql.datapage.app/documentation.sql</loc>
<lastmod>2024-10-10</lastmod>
<priority>0.80</priority>
</url>
<url>
<loc>https://sql.datapage.app/your-first-sql-website/</loc>
<lastmod>2024-10-10</lastmod>
<priority>0.80</priority>
</url>
Comment on lines +19 to +22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to have such a little subset of the site in the sitemap ? Won't it penalize other pages ?

We should probably either not have a sitemap, or have one that is generated dynamically in sql

</urlset>