Skip to content

add function sqlpage.client_ip() #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add function sqlpage.client_ip() #813

wants to merge 1 commit into from

Conversation

@Kitsune-Kuro
Copy link
Contributor

All RequestInfos can be called via functions, except client_ip.
I would like to change that.

lovasoa
lovasoa requested changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we add it to the documentation, and return NULL (None) instead of panicking when the field is absent?

@lovasoa
Copy link
Collaborator

lovasoa commented Feb 17, 2025

I made the changes and merged. Thank you !

@lovasoa lovasoa closed this Feb 17, 2025
@Kitsune-Kuro Kitsune-Kuro deleted the patch-2 branch February 17, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovasoa lovasoa lovasoa requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kitsune-Kuro @lovasoa