Skip to content

Option to completely hide the footer from the shell.handlebars template #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Option to completely hide the footer from the shell.handlebars template #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
514ecd4
shell.handlebars: remove footer when it is exactly an empty string
francesco-cattoglio Feb 28, 2025
ff14925
Update CHANGELOG.md
francesco-cattoglio Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- `markdown_allow_dangerous_html`: allow the usage of html in markdown (default: false)
- `markdown_allow_dangerous_protocol`: allow the usage of custom protocols in markdown (default: false)
- see [configuration.md](./configuration.md) for more details.
- In the shell component, setting the `footer` parameter to the empty string (`''`) will now completely hide the footer, instead of showing the default one

## 0.33.1 (2025-02-25)

Expand Down
22 changes: 12 additions & 10 deletions sqlpage/templates/shell.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,16 +214,18 @@
{{~#each_row~}}{{~/each_row~}}
</main>

<footer class="w-100 text-center fs-6 my-2 text-secondary" id="sqlpage_footer">
{{#if footer}}
{{{markdown footer}}}
{{else}}
<!-- You can change this footer using the 'footer' parameter of the 'shell' component -->
Built with <a class="text-reset" href="https://sql-page.com"
title="SQLPage v{{buildinfo 'CARGO_PKG_VERSION'}}">SQLPage</a>
{{/if}}
</footer>
{{#unless (eq footer '')}}
<footer class="w-100 text-center fs-6 my-2 text-secondary" id="sqlpage_footer">
{{#if footer}}
{{{markdown footer}}}
{{else}}
<!-- You can change this footer using the 'footer' parameter of the 'shell' component -->
Built with <a class="text-reset" href="https://sql-page.com"
title="SQLPage v{{buildinfo 'CARGO_PKG_VERSION'}}">SQLPage</a>
{{/if}}
</footer>
{{/unless}}
</div>
</div>
</body>
</html>
</html>