New modal component #934
Merged
New modal component #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opening of a modal box
lovasoa
reviewed
Jun 8, 2025
lovasoa
reviewed
Jun 8, 2025
|
Thank you very much for this contribution ! Are you using this component already in your projects ? In which context ? The inability to dynamically open the modal seems a little bit impractical. |
Yes, I use it in my projects. The opening of modal boxes is triggered by the Button component. I use them to display additional information or contextual help. Modal boxes can also be opened with javascript. |
|
Merci Olivier ! Sorry for merging so late; and thanks again for this contribution. I'll maybe rework this a little, and it will be in the next version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New modal component and upgrade of the button component to allow the opening of a modal box.