Implement OIDC metadata caching with expiration #979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reported by @alexisrc1 |
Co-authored-by: contact <[email protected]>
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 9, 2025
Learn more in the Cursor dashboard.
…ling Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
…eatures - Preserved production-grade OIDC metadata caching implementation - Added support for multiple JWT audiences from main branch - Updated function signatures to match main (process_oidc_callback, get_authenticated_user_info) - Added handle_authenticated_oidc_callback support for already-authenticated users - Maintained async caching functionality with proper HTTP client access - Resolved all merge conflicts while keeping both new features and security fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement OIDC provider metadata caching to support key rotation and improve robustness.
Previously, OIDC provider metadata was discovered only once at startup and never refreshed, which prevented the system from picking up rotated signing keys and could lead to authentication failures or security vulnerabilities. This PR introduces a caching mechanism that refreshes the metadata and recreates the OIDC client on-demand, with a 24-hour cache duration and a 5-minute minimum refresh interval, ensuring key rotation is handled gracefully while providing robust fallback behavior.
Open in Web • Open in Cursor • Open Docs