fix: more clippy warnings in sqlite modules

- Fix unused_mut in sqlite/connection/execute.rs
- Fix manual_inspect by using inspect instead of map
- Fix derivable_impls by deriving Default for sqlite option enums
- Fix map_clone by using copied() method
- Fix legacy_numeric_constants by using i32::MAX instead of importing

Author: cursoragent

sqlx-core/src/sqlite/connection/execute.rs

@@ -68,7 +68,7 @@ impl Iterator for ExecuteIter<'_> {
 
     fn next(&mut self) -> Option<Self::Item> {
         let statement = if self.goto_next {
-            let mut statement = match self.statement.prepare_next(self.handle) {
+            let statement = match self.statement.prepare_next(self.handle) {
                 Ok(Some(statement)) => statement,
                 Ok(None) => return None,
                 Err(e) => return Some(Err(e)),

sqlx-core/src/sqlite/connection/worker.rs

@@ -124,12 +124,11 @@ impl ConnectionWorker {
                 for cmd in command_rx {
                     match cmd {
                         Command::Prepare { query, tx } => {
-                            tx.send(prepare(&mut conn, &query).map(|prepared| {
+                            tx.send(prepare(&mut conn, &query).inspect(|_| {
                                 update_cached_statements_size(
                                     &conn,
                                     &shared.cached_statements_size,
                                 );
-                                prepared
                             }))
                             .ok();
                         }

sqlx-core/src/sqlite/options/auto_vacuum.rs

@@ -1,8 +1,9 @@
 use crate::error::Error;
 use std::str::FromStr;
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 pub enum SqliteAutoVacuum {
+    #[default]
     None,
     Full,
     Incremental,
@@ -18,11 +19,6 @@ impl SqliteAutoVacuum {
     }
 }
 
-impl Default for SqliteAutoVacuum {
-    fn default() -> Self {
-        SqliteAutoVacuum::None
-    }
-}
 
 impl FromStr for SqliteAutoVacuum {
     type Err = Error;

sqlx-core/src/sqlite/options/journal_mode.rs

@@ -4,12 +4,13 @@ use std::str::FromStr;
 /// Refer to [SQLite documentation] for the meaning of the database journaling mode.
 ///
 /// [SQLite documentation]: https://www.sqlite.org/pragma.html#pragma_journal_mode
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 pub enum SqliteJournalMode {
     Delete,
     Truncate,
     Persist,
     Memory,
+    #[default]
     Wal,
     Off,
 }
@@ -27,11 +28,6 @@ impl SqliteJournalMode {
     }
 }
 
-impl Default for SqliteJournalMode {
-    fn default() -> Self {
-        SqliteJournalMode::Wal
-    }
-}
 
 impl FromStr for SqliteJournalMode {
     type Err = Error;

sqlx-core/src/sqlite/options/locking_mode.rs

@@ -4,8 +4,9 @@ use std::str::FromStr;
 /// Refer to [SQLite documentation] for the meaning of the connection locking mode.
 ///
 /// [SQLite documentation]: https://www.sqlite.org/pragma.html#pragma_locking_mode
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 pub enum SqliteLockingMode {
+    #[default]
     Normal,
     Exclusive,
 }
@@ -19,11 +20,6 @@ impl SqliteLockingMode {
     }
 }
 
-impl Default for SqliteLockingMode {
-    fn default() -> Self {
-        SqliteLockingMode::Normal
-    }
-}
 
 impl FromStr for SqliteLockingMode {
     type Err = Error;

sqlx-core/src/sqlite/options/synchronous.rs

@@ -4,10 +4,11 @@ use std::str::FromStr;
 /// Refer to [SQLite documentation] for the meaning of various synchronous settings.
 ///
 /// [SQLite documentation]: https://www.sqlite.org/pragma.html#pragma_synchronous
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 pub enum SqliteSynchronous {
     Off,
     Normal,
+    #[default]
     Full,
     Extra,
 }
@@ -23,11 +24,6 @@ impl SqliteSynchronous {
     }
 }
 
-impl Default for SqliteSynchronous {
-    fn default() -> Self {
-        SqliteSynchronous::Full
-    }
-}
 
 impl FromStr for SqliteSynchronous {
     type Err = Error;

sqlx-core/src/sqlite/row.rs

@@ -74,8 +74,8 @@ impl ColumnIndex<SqliteRow> for &'_ str {
     fn index(&self, row: &SqliteRow) -> Result<usize, Error> {
         row.column_names
             .get(*self)
+            .copied()
             .ok_or_else(|| Error::ColumnNotFound((*self).into()))
-            .map(|v| *v)
     }
 }
 

sqlx-core/src/sqlite/statement/virtual.rs

@@ -14,7 +14,7 @@ use smallvec::SmallVec;
 use std::os::raw::c_char;
 use std::ptr::{null, null_mut, NonNull};
 use std::sync::Arc;
-use std::{cmp, i32};
+use std::cmp;
 
 // A virtual statement consists of *zero* or more raw SQLite3 statements. We chop up a SQL statement
 // on `;` to support multiple statements in one query.
@@ -72,7 +72,7 @@ impl VirtualStatement {
             }
         }
 
-        if query.len() > i32::max_value() as usize {
+        if query.len() > i32::MAX as usize {
             return Err(err_protocol!(
                 "query string must be smaller than {} bytes",
                 i32::MAX